Improve account copying#1069
Merged
braginini merged 1 commit intonetbirdio:mainfrom Aug 22, 2023
Merged
Conversation
surik
force-pushed
the
improve-account-copying
branch
from
16cff27 to
0384be8
Compare
braginini
previously approved these changes
Aug 10, 2023
surik
force-pushed
the
improve-account-copying
branch
from
0384be8 to
232985b
Compare
With this fix, all nested slices and pointers will be copied by value. Also, this fixes tests to compare the original and copy account by their values by marshaling them to JSON strings. Before that, they were copying the pointers that also passed the simple `=` compassion (as the addresses match).
surik
force-pushed
the
improve-account-copying
branch
from
232985b to
543055d
Compare
braginini
approved these changes
Aug 22, 2023
pulsastrix
pushed a commit
to pulsastrix/netbird
that referenced
this pull request
Dec 24, 2023
With this fix, all nested slices and pointers will be copied by value. Also, this fixes tests to compare the original and copy account by their values by marshaling them to JSON strings. Before that, they were copying the pointers that also passed the simple `=` compassion (as the addresses match).
Foosec
pushed a commit
to Foosec/netbird
that referenced
this pull request
May 8, 2024
With this fix, all nested slices and pointers will be copied by value. Also, this fixes tests to compare the original and copy account by their values by marshaling them to JSON strings. Before that, they were copying the pointers that also passed the simple `=` compassion (as the addresses match).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this fix, all nested slices and pointers will be copied by value.
Also, this fixes tests to compare the original and copy account by their values by marshaling them to JSON strings.
Before that, they were copying the pointers that also passed the simple
=compassion (as the addresses match).Describe your changes
Issue ticket number and link
Checklist