[management] permission manager validate account access

[pnmcosta]

Describe your changes

Issue ticket number and link

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

[mlsmaycon]

@pnmcosta can you handle sonar findings?

[Copilot]

Pull Request Overview

This PR refactors the account management code to integrate a centralized permissions manager and adds new functionality to create and update accounts by private domain.

• Introduces two new methods: CreateAccountByPrivateDomain and UpdateToPrimaryAccount.
• Replaces direct account ID checks with calls to permissionsManager.ValidateAccountAccess in various methods.
• Updates BuildManager signature, tests, and mocks throughout the codebase to support the new permissions manager.

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
management/server/account.go	Added new account creation/update methods and replaced direct checks with permissions validation.
management/server/event.go	Updated event handling to populate user info with permissions considerations.
management/server/account_test.go	Added tests for new methods and updated BuildManager usage to pass permissions manager.
management/server/peer.go	Replaced direct account checks with calls to permissionsManager.ValidateAccountAccess.
management/server/mock_server/account_mock.go	Added mocks for the new methods.
management/server/dns*.go, nameserver*.go, group.go	Replaced direct user.AccountID comparisons with permissions validation calls.
client/internal/engine_test.go, client/cmd/testutil_test.go, etc.	Updated tests to include the new permissions manager dependency.
management/cmd/management.go	Updated BuildManager call to initialize the permissions manager via integrations.
management/server/http/handlers/events/events_handler.go	Removed unused legacy event metadata filling code.

Comments suppressed due to low confidence (2)

management/server/account.go:1714

• [nitpick] Consider replacing the magic number '2' with a named constant (e.g., retryCount) to improve clarity and maintainability.

for range 2 {

management/server/account.go:1110

• The direct check 'user.AccountID != accountID' has been replaced with permissionsManager.ValidateAccountAccess; ensure that the new validation call handles all the required permission scenarios consistently.

if user.AccountID != accountID {

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud