[management] fix extend call and move config to types #3575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this helps avoid circular import cycle through all the code
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes configuration inconsistencies and updates the store engine type usage throughout the management code. Key changes include:
- Replacing outdated server.Config references with types.Config and updating related flag variables (e.g. types.MgmtConfigPath).
- Converting engine constants (SqliteStoreEngine, PostgresStoreEngine, MysqlStoreEngine) to use types.Engine for consistent type–safety.
- Adjusting various test and migration code paths to correctly reference the new configuration and engine types.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| management/server/grpcserver.go | Updated config argument and protocol conversion to use types.Config. |
| management/server/types/config.go | Switched package and added MgmtConfigPath variable for config file path. |
| management/cmd/root.go | Revised flag registration to bind config flag to types.MgmtConfigPath. |
| management/server/store/*.go | Converted engine constants and function signatures to use types.Engine. |
| management/server/peer.go | Updated calls to toSyncResponse to use types.Config (with one inconsistent call). |
| management/cmd/management.go | Replaced server.Config with types.Config in config loading and updating. |
| Various test files | Adjusted type references in tests to use types.Config and types.Host. |
| management/server/token_mgr.go | Updated TURN/Relay config references to use types.TURNConfig/Relay. |
mlsmaycon
changed the title
|
pascal-fischer
approved these changes
Mar 27, 2025
remipcomaite
pushed a commit
to remipcomaite/netbird
that referenced
this pull request
Apr 9, 2025
This PR fixes configuration inconsistencies and updates the store engine type usage throughout the management code. Key changes include: - Replacing outdated server.Config references with types.Config and updating related flag variables (e.g. types.MgmtConfigPath). - Converting engine constants (SqliteStoreEngine, PostgresStoreEngine, MysqlStoreEngine) to use types.Engine for consistent type–safety. - Adjusting various test and migration code paths to correctly reference the new configuration and engine types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fixes configuration inconsistencies and updates the store engine type usage throughout the management code. Key changes include:
Issue ticket number and link
Checklist