Add disable letsencrypt#747
Merged
Merged
Conversation
|
|
Contributor
Author
|
I have also marked the doc-changes as ready: netbirdio/docs#34 |
pulsastrix
pushed a commit
to pulsastrix/netbird
that referenced
this pull request
Dec 24, 2023
Add NETBIRD_DISABLE_LETSENCRYPT support to explicit disable let's encrypt Organize the setup.env.example variables into sections Add traefik example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the setup-option
NETBIRD_DISABLE_LETSENCRYPTinsetup.env.exampleto allow disabling the internal letsencrypt-setup.e.g. for use with a reverse-proxy or to ship own letsencrypt-certs from an external-system.
For this i also had to add some env-setup-variables.
I also reordered the compose aswell as the setup.env file to make it more readable.
When running configure with
NETBIRD_DISABLE_LETSENCRYPT=truethe user is informed about actions he must take to get a working setup.I have also prepared doc-changes to include more extensive documentation about using netbird behind a reverse-proxy and shipped an example-file for traefik.
I plan to submit that PR when this one is accepted.EDIT: PR for docs
But I am not 100% happy with how much the user has to edit to archive such a setup, but i think the example-files will help alot.
(Maybe combine the domains and ports, so only 1 thing has to be changed?)