Optimize ACL performance#994
Merged
Merged
Conversation
Handle rules which contains as peer IP 0.0.0.0. This type of rules generated by the managemnet when one of the side contains All group.
mlsmaycon
requested changes
Jul 16, 2023
pascal-fischer
approved these changes
Jul 17, 2023
mlsmaycon
approved these changes
Jul 17, 2023
surik
pushed a commit
to surik/netbird
that referenced
this pull request
Aug 11, 2023
* Optimize rules with All groups * Use IP sets in ACLs (nftables implementation) * Fix squash rule when we receive optimized rules list from management
surik
pushed a commit
to surik/netbird
that referenced
this pull request
Aug 14, 2023
* Optimize rules with All groups * Use IP sets in ACLs (nftables implementation) * Fix squash rule when we receive optimized rules list from management
pulsastrix
pushed a commit
to pulsastrix/netbird
that referenced
this pull request
Dec 24, 2023
* Optimize rules with All groups * Use IP sets in ACLs (nftables implementation) * Fix squash rule when we receive optimized rules list from management
Foosec
pushed a commit
to Foosec/netbird
that referenced
this pull request
May 8, 2024
* Optimize rules with All groups * Use IP sets in ACLs (nftables implementation) * Fix squash rule when we receive optimized rules list from management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Reduce rules count generated on the management side. Use sets on the client side for firewalls in kernel implementation
Issue ticket number and link
Checklist