Rename variables 'version' to 'api_version' and 'full_version' to 'netbox_version' #1493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
None
New Behavior
None
...
Contrast to Current Behavior
None
...
Discussion: Benefits and Drawbacks
The current variable names
versionandfull_versioncan be ambiguous, as it’s not immediately clear whether they refer to the API version, the NetBox application version, or something else.This change renames them to:
api_version→ clearly indicates the version of the NetBox API being used.netbox_version→ explicitly refers to the full NetBox application version.Benefits:
...
Changes to the Documentation
None
...
Proposed Release Note Entry
versiontoapi_version.full_versiontonetbox_version....
Double Check
develbranch.