Adapting deploy-netbox.sh to a vCluster deployment #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogarciamiranda
changed the title
pablogarciamiranda
changed the title
faebr
requested changes
Apr 29, 2025
bruelea
requested changes
Apr 30, 2025
faebr
requested changes
May 2, 2025
Collaborator
Author
Collaborator
thanks, looks good to me now. There is still an open conversation with @bruelea which I believe is not resolved yet? There is a mixup between namespace for the vcluster deployment and namespace for the netbox deployment. |
…PACE passed as an argument
bruelea
approved these changes
May 5, 2025
faebr
approved these changes
May 5, 2025
vaishutin
pushed a commit
to vaishutin/netbox-operator
that referenced
this pull request
Aug 17, 2025
) * Adapting deploy-netbox.sh to a vCluster deployment * Debugging demo data * Adding steps to load demo-data into NetBox inside the vcluster * Adding description to script * Adding kind path * Adding namespaces * Removing sleep used for testing purposes * Fixing script comment * Adding variable IS_VCLUSTER to easily check in all the if statements * Refactoring part of loading demo-data into NetBox * Removing unnecessary code & comments * Adding comment to clarify that vCluster will be deployed to the NAMESPACE passed as an argument --------- Co-authored-by: Pablo Garcia Miranda <pablo.garciamiranda@swisscom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've adapted the deploy-netbox.sh script as it could be useful to run netbox inside a vCluster for testing purposes.
I've just added a
--vclusterto activate the mode. Otherwise, by default, it will deploy to a kind cluster as it's the case now.How to test?
VCluster Mode (new)
Kind Mode (existing)