Allow overriding image registry and Helm chart sources in NetBox deploy script #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry instead of public repositories for binaries and helm charts
…PACE passed as an argument
…PACE passed as an argument
…is is set, otherwise, don't pass the flag and use the default one from the chart
…if this is set, otherwise, don't pass the flag and use the default one from the chart
pablogarciamiranda
changed the base branch from
feature/deploy-netbox-vcluster
to
main
# Conflicts: # kind/deploy-netbox.sh
bruelea
requested changes
May 6, 2025
Collaborator
bruelea
left a comment
bruelea
left a comment
There was a problem hiding this comment.
in the netbox-db.yaml the field 'dockerImage' can be added to the spec, to define which image to use for the netbox-db pod. Otherwise it will fail with ImagePullBackOff error.
… script to load the local data
bruelea
approved these changes
Jun 6, 2025
vaishutin
pushed a commit
to vaishutin/netbox-operator
that referenced
this pull request
Aug 17, 2025
…oy script (netbox-community#296) * Adapting deploy-netbox.sh to a vCluster deployment * Debugging demo data * Adding steps to load demo-data into NetBox inside the vcluster * Adding description to script * Adding kind path * Adding namespaces * Removing sleep used for testing purposes * Fixing script comment * Adding variable IS_VCLUSTER to easily check in all the if statements * Refactoring part of loading demo-data into NetBox * Parametrizing deploy-netbox.sh to allower using a customize artifactory instead of public repositories for binaries and helm charts * Create patch to inject the NETBOX_SQL_DUMP_URL inside the Docker container * Removing unnecessary code & comments * Removing from kustomization.yaml the new changes applied in the script * Adding comment to script and renaming SQL_DUMP_URL to NETBOX_SQL_DUMP_URL * Adding comment to clarify that vCluster will be deployed to the NAMESPACE passed as an argument * Adding comment to clarify that vCluster will be deployed to the NAMESPACE passed as an argument * Adding image.registry to the values of the two helm charts to be installed * Removing newImage & newTag from kustomization.yaml * Simplifying use of env variables * Assign IMAGE_REGISTRY to the helm upgrade from the env variable if this is set, otherwise, don't pass the flag and use the default one from the chart * Fix: Assign IMAGE_REGISTRY to the helm upgrade from the env variable if this is set, otherwise, don't pass the flag and use the default one from the chart * Setting a SCRIPT_DIR that it's used all over the script * Using HELM_REPOS instead of HELM_CHARTS for env substitution * Adding a patch to the kind: postgresql spec.dockerImage * Remove Dockerfile and use a ConfigMap mounting the main.py to run the script to load the local data * Using PYPI_REPOSITORY_URL instead of ARTIFACTORY_PYPI_URL * Refactoring of scripts to inject dynamically env variables * minor fixes * add empty lines at end of file * remove debug comments * fix default python image registry --------- Co-authored-by: Pablo Garcia Miranda <pablo.garciamiranda@swisscom.com> Co-authored-by: bruelea <166021996+bruelea@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
deploy-netbox.shscript to make it agnostic of any specific image repository or Artifactory instance.Tests
Without env variables
Deploy netbox into a kind cluster with no ENV variables exported
Deploy netbox into a vcluster with no ENV variables exported
With env variables
By exporting the following variables, users can override default URLs and images to point to their repositories:
Deploy netbox into a kind cluster with no ENV variables exported
Deploy netbox into a vcluster with no ENV variables exported