Skip to content

#11150: Add a filter for device.primary_ip4 and primary_ip6 #11382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2023
Merged

#11150: Add a filter for device.primary_ip4 and primary_ip6 #11382

merged 2 commits into from
Jan 5, 2023

Conversation

michaelarnauts
Copy link
Contributor

Fixes: #11150

  • Add primary_ip4 and primary_ip6 to the DeviceFilterSet
  • Add tests to query based on those fields

@michaelarnauts michaelarnauts mentioned this pull request Jan 4, 2023
Closed
@jeremystretch
Copy link
Member

Thanks @michaelarnauts! I've extended your tests just a bit to test querying multiple IDs, but this is great!

@jeremystretch jeremystretch merged commit 5d22260 into netbox-community:develop Jan 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a filter for device.primary_ip4 and primary_ip6 to the REST API / graphQL

2 participants

@michaelarnauts @jeremystretch