Skip to content

Closes #16388: Move change logging resources from extras to core #16545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2024
Merged

Closes #16388: Move change logging resources from extras to core #16545

merged 2 commits into from
Jun 17, 2024

Conversation

jeremystretch
Copy link
Member

Fixes: #16388

  • Move the ObjectChange model & related resources (views, forms, tests, etc.) from the extras app to the core app
  • Write migrations to rename the existing table and avoid altering existing data
  • Move the event_tracking() context manager into netbox

@jeremystretch jeremystretch marked this pull request as ready for review June 13, 2024 17:34
@jeremystretch jeremystretch requested a review from arthanson June 13, 2024 17:34
arthanson
arthanson approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As separate Housekeeping - should we move object-types to core as well? Seem they fit there?

@jeremystretch jeremystretch merged commit 853d990 into feature Jun 17, 2024
@jeremystretch jeremystretch deleted the 16388-move-change-logging branch June 17, 2024 12:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arthanson arthanson arthanson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeremystretch @arthanson