Skip to content

Fixes #20584: Ensure consistent validation between Interface & InterfaceTemplate #20589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

Fixes #20584: Ensure consistent validation between Interface & InterfaceTemplate #20589

merged 1 commit into from
Oct 15, 2025

Conversation

jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Oct 15, 2025 •
edited
Loading

Fixes: #20584

  • Introduce InterfaceValidationMixin to hold validation logic common to both Interface and InterfaceTemplate
  • Move the applicable logic over from Interface
  • Remove redundant logic from InterfaceTemplate.clean()

@jeremystretch jeremystretch force-pushed the 20584-interface-template-validation branch from 4f8d3db to 725f2a3 Compare October 15, 2025 16:20
@jeremystretch jeremystretch marked this pull request as ready for review October 15, 2025 16:21
@jeremystretch jeremystretch requested review from a team and arthanson and removed request for a team October 15, 2025 16:21
@arthanson arthanson merged commit addda05 into main Oct 15, 2025
10 checks passed
@jeremystretch jeremystretch deleted the 20584-interface-template-validation branch October 15, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arthanson arthanson arthanson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Interface template with PoE type set should require a PoE mode

2 participants

@jeremystretch @arthanson