Skip to content

Fixes #20660: Optimize loading of custom script modules from remote storage #20783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
+2 −3
Merged

Fixes #20660: Optimize loading of custom script modules from remote storage #20783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions netbox/extras/models/mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ def create_module(self, spec):
return None # Use default module creation

def exec_module(self, module):
storage = storages.create_storage(storages.backends["scripts"])
with storage.open(self.filename, 'rb') as f:
with storages["scripts"].open(self.filename, 'rb') as f:
code = f.read()
exec(code, module.__dict__)

Expand Down
2 changes: 1 addition & 1 deletion netbox/extras/models/scripts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def ordered_scripts(self):
ordered.extend(script_objects.values())
return ordered

@property
@cached_property
def module_scripts(self):

def _get_name(cls):
Expand Down