-
Notifications
You must be signed in to change notification settings - Fork 186
feat(image): add image upload support #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(image): add image upload support #716
Conversation
|
@NeverBehave please don't request reviews from individuals unless someone has previously volunteered. We utilize a rotation for assignment of reviewers. |
|
@jeremystretch The request is sent automatically(and won't be able to deselect) by Github since this repo has defined CODEOWNERS, which was added 7 month ago by @arthanson |
|
My mistake, thanks for pointing that out. Not sure why that was added as it's not needed. I've opened #717 to remove it. |
arthanson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NeverBehave this looks very good, just a couple questions below.
|
@arthanson thanks for the review. Both cases updated with corresponded tests covered. Let me know if there is any other concerns. |
|
@NeverBehave some of the tests are failing, can you please check |
Fixes: #520
This PR adds automatic file upload support for endpoints that accept files (e.g., image attachments, device type images).
Changes:
create()/save()data and switch from JSON tomultipart/form-dataencoding_is_file_like()and_extract_files()in query.py