Skip to content

feat: add api client for diode auth credentials api #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: feat: client credentials management
merged 1 commit into from
May 15, 2025
Merged

feat: add api client for diode auth credentials api #104

merged 1 commit into from
May 15, 2025

Conversation

@ltucker
Copy link
Contributor

@ltucker ltucker commented May 15, 2025 •
edited
Loading

Adding in an api client wrapper / credential configuration for calling the diode auth client management endpoints.

@ltucker ltucker requested a review from arthanson May 15, 2025 00:44
@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3107 2721 88% 0% 🟢

New Files

File Coverage Status
netbox_diode_plugin/diode/clients.py 18% 🟢
TOTAL 18% 🟢

Modified Files

File Coverage Status
netbox_diode_plugin/init.py 100% 🟢
netbox_diode_plugin/client.py 50% 🟢
netbox_diode_plugin/plugin_config.py 68% 🟢
TOTAL 73% 🟢

updated for commit: c427d24 by action🐍

mfiedorowicz
mfiedorowicz reviewed May 15, 2025
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we add some basic unit tests for diode ClientAPI?

Also some linter/ruff issues detected

netbox_diode_plugin/diode/clients.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some basic tests for ClientAPI, please?

@arthanson arthanson merged commit 537f45a into OBS-1046-client May 15, 2025
3 checks passed
@arthanson arthanson deleted the client_sdk branch May 15, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz left review comments

@arthanson arthanson arthanson approved these changes

@leoparente leoparente Awaiting requested review from leoparente

Assignees

No one assigned

Labels

internal markdown python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ltucker @arthanson @mfiedorowicz