Skip to content

Conversation

@arthanson
Copy link
Contributor

Adds client secret list, add, delete views. Secret is only displayed on creation.

Monosnap Add a Client Secret | NetBox 2025-05-15 13-45-30
Monosnap Add Client Credential | NetBox 2025-05-15 13-49-55
Monosnap Client Credentials | NetBox 2025-05-15 13-44-41
Monosnap Delete cc1? | NetBox 2025-05-15 13-45-44

@CLAassistant
Copy link

CLAassistant commented May 15, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented May 15, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3227 2879 89% 0% 🟢

New Files

File Coverage Status
netbox_diode_plugin/client.py 39% 🟢
netbox_diode_plugin/diode/clients.py 70% 🟢
netbox_diode_plugin/tables.py 77% 🟢
netbox_diode_plugin/tests/test_diode_clients.py 100% 🟢
TOTAL 72% 🟢

Modified Files

File Coverage Status
netbox_diode_plugin/init.py 100% 🟢
netbox_diode_plugin/forms.py 100% 🟢
netbox_diode_plugin/models.py 100% 🟢
netbox_diode_plugin/navigation.py 100% 🟢
netbox_diode_plugin/plugin_config.py 68% 🟢
netbox_diode_plugin/urls.py 100% 🟢
netbox_diode_plugin/views.py 55% 🟢
TOTAL 89% 🟢

updated for commit: 7c07bfe by action🐍

ltucker and others added 3 commits May 15, 2025 23:06
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…mote source

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
ltucker and others added 2 commits May 15, 2025 23:12
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copy link
Contributor

@ltucker ltucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cleaned up lint on here, added some unit tests on the api client and merged most of the security fixes. Looks good to me if you can take a look / make a call on whatever it's suggesting on the next_url redirect.

@mfiedorowicz mfiedorowicz changed the title Obs 1046 client feat: client credentials management May 16, 2025
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more important feedback to consider

@ltucker ltucker merged commit 5721150 into develop May 16, 2025
6 checks passed
@ltucker ltucker deleted the OBS-1046-client branch May 16, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants