-
Notifications
You must be signed in to change notification settings - Fork 12
feat: prevent duplicate component creation from templates #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
jajeffries
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good - couple of minor suggestions but happy for it to go in as is
…rove readability Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
…ting instances Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
jajeffries
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This pull request improves the handling of auto-created component objects (such as interfaces and module bays) to prevent duplicate creation when applying changes through the API. It introduces logic to detect and update existing components that were instantiated from templates, ensuring that incoming changes reuse and update these objects rather than creating new duplicates. The changes are validated with new tests that verify correct reuse and updating of components.
Component Deduplication Logic:
_apply_changeinnetbox_diode_plugin/api/applier.pyto check for existing auto-created components (likedcim.interface,dcim.modulebay, etc.) before creating new ones, and to update them if found instead of creating duplicates.Testing Improvements:
test_module_bay_from_template_no_duplicateandtest_interface_from_template_no_duplicatetonetbox_diode_plugin/tests/test_api_apply_change_set.pyto verify that module bays and interfaces created from templates are reused and updated, not duplicated, when ingested via API changes.Operational Tuning:
start_periodfor the NetBox service indocker/docker-compose.yamlfrom 60s to 180s to allow more time for startup before healthchecks begin.