fix: loosen gRPC DNS error message assertion in test_client_error#89
Merged
mfiedorowicz merged 1 commit intodevelopfrom Apr 16, 2026
Conversation
The assertion checked for a specific gRPC DNS error message format that changed across gRPC versions. Check for the hostname instead, which is present in all message variants. Resolves OBS-2681
mfiedorowicz
requested review from
MicahParks,
jajeffries,
leoparente and
ltucker
as code owners
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||
jajeffries
approved these changes
Apr 16, 2026
mfiedorowicz
deleted the
obs-2681-fix-flaky-test_client_error-assertion-for-grpc-dns-error
branch
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_client_errorassertion to check for"invalid:8081"in gRPC error details instead of a specific DNS error message formatTest plan
pytest tests/test_client.py::test_client_errorand verify it passesResolves OBS-2681