feat: add metadata #427
Merged
feat: add metadata #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
github-actions
bot
added
documentation
|
Go test coverage
Total coverage: 54.4% |
mfiedorowicz
requested review from
MicahParks,
jajeffries,
leoparente and
ltucker
as code owners
leoparente
approved these changes
Nov 17, 2025
barryCrunch
pushed a commit
to barryCrunch/diode
that referenced
this pull request
Nov 26, 2025
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the protobuf schema in
diode-proto/diode/v1/ingester.proto, mainly by adding ametadatafield to many message types and defining a custom field option for NetBox support. Additionally, the Makefile is updated to ensure generated Go code is formatted automatically. These changes improve extensibility and maintainability for future integrations and custom metadata handling.Protobuf schema enhancements:
google.protobuf.Struct metadatafield to a wide range of message types (e.g.,ASN,Device,Interface, etc.), enabling flexible storage of additional structured data. In most cases, this field is explicitly marked as not supported by NetBox using a new custom field option. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28] [29] [30] [31] [32] [33] [34] [35] [36] [37]netbox_supported(bool) for protobuf fields, allowing schema consumers to determine if a field is supported by NetBox.google/protobuf/descriptor.protoandgoogle/protobuf/struct.prototo support the new metadata field and custom options.Build and formatting improvements:
gofmton generated Go SDK and server code, ensuring consistent code formatting after code generation. [1] [2]