Fixes #371: Ignore module import errors when discovering object migrators #372
Conversation
jeremystretch
requested review from
a team and
arthanson
and removed request for
a team
|
Thanks for this, I've applied the change manually and its fixed the issue. |
| try: | ||
| module = importlib.import_module(f'{app_label}.migrations.{name}') | ||
| except ModuleNotFoundError: | ||
| logger = logging.getLogger('netbox_branching.branch') |
There was a problem hiding this comment.
I see the pattern in this file is to instantiate a new logger for every log line, which I guess makes sense since they're all routed differently for different purposes; but I'd think a more common/less chatty pattern would be to declare all the various loggers at the top instead of ad-hoc. Just a note for consideration though, not a reason to block this merge.
There was a problem hiding this comment.
I think in this case it's okay because we're only invoking the logger in the event a failure occurs, which should be rare. We should probably devise a more robust logging strategy generally, but that's outside the scope of this bug fix.
Fixes: #371
This specifically addresses a known issue with
sorl-thumbnail, but applies a general workaround.