fix: netbox_search_objects now extracts 'results' array from NetBox's paginated response structure instead of returning the full '{count, next, previous, results}' dict as it is not equipped for pagination #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… paginated response structure instead of returning the full '{count, next, previous, results}' dict as it is not equipped for pagination
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where netbox_search_objects was returning NetBox's full paginated API response structure (containing count, next, previous, and results fields) instead of just the results array. The function now correctly extracts the results array from the response.
Key changes:
- Modified
netbox_search_objectsto extract theresultsarray from NetBox's paginated response structure - Updated all test mocks to return the correct paginated response format matching NetBox API behavior
- Added comprehensive test case to verify proper extraction of results from paginated responses
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| server.py | Updated netbox_search_objects to extract results array from paginated API response using response.get("results", []) |
| tests/test_search.py | Updated all mock responses to return realistic paginated response structure and added new test case validating results extraction |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ltucker
changed the title
ltucker
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.