-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add default yaml config file for fleet config manager #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go test coverage
Total coverage: 57.5% |
MicahParks
reviewed
Oct 22, 2025
jajeffries
approved these changes
Oct 24, 2025
Contributor
jajeffries
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new default configuration file for the orb agent, updates the Docker image to include this file, and makes minor dependency adjustments in the Go module file. The main focus is on improving configuration management and ensuring the Docker image has the necessary defaults for deployment.
Configuration management improvements:
default_config.yamlfile that provides default configuration values for the orb agent, including config manager settings, backend definitions, and integration with external services using environment variables.default_config.yamlinto the Docker image at/opt/orb/default_config.yaml, ensuring the agent has access to default settings at runtime.Dependency updates:
go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttpand madegoogle.golang.org/grpcan indirect dependency ingo.modto clean up unused or unnecessary dependencies. [1] [2]