Skip to content

Conversation

@leoparente
Copy link
Contributor

@leoparente leoparente commented Oct 17, 2025

This pull request introduces a new default configuration file for the orb agent, updates the Docker image to include this file, and makes minor dependency adjustments in the Go module file. The main focus is on improving configuration management and ensuring the Docker image has the necessary defaults for deployment.

Configuration management improvements:

  • Added a new default_config.yaml file that provides default configuration values for the orb agent, including config manager settings, backend definitions, and integration with external services using environment variables.
  • Updated the Dockerfile to copy the new default_config.yaml into the Docker image at /opt/orb/default_config.yaml, ensuring the agent has access to default settings at runtime.

Dependency updates:

  • Removed the direct dependency on go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp and made google.golang.org/grpc an indirect dependency in go.mod to clean up unused or unnecessary dependencies. [1] [2]

@leoparente leoparente self-assigned this Oct 17, 2025
@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent 0.0% 0 0 0
🟢 PASS 1.11s github.com/netboxlabs/orb-agent/agent/backend 33.3% 30 0 0
🟢 PASS 4.03s github.com/netboxlabs/orb-agent/agent/backend/devicediscovery 67.1% 2 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/backend/mocks 0.0% 0 0 0
🟢 PASS 4.03s github.com/netboxlabs/orb-agent/agent/backend/networkdiscovery 59.0% 2 0 0
🟢 PASS 4.02s github.com/netboxlabs/orb-agent/agent/backend/opentelemetryinfinity 46.3% 2 0 0
🟢 PASS 4.03s github.com/netboxlabs/orb-agent/agent/backend/pktvisor 67.0% 2 0 0
🟢 PASS 4.03s github.com/netboxlabs/orb-agent/agent/backend/snmpdiscovery 58.5% 2 0 0
🟢 PASS 5.03s github.com/netboxlabs/orb-agent/agent/backend/worker 68.1% 3 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/config 100.0% 6 0 0
🟢 PASS 31.19s github.com/netboxlabs/orb-agent/agent/configmgr 51.5% 18 0 0
🟢 PASS 4.53s github.com/netboxlabs/orb-agent/agent/configmgr/fleet 71.3% 126 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/policies 100.0% 15 0 0
🟢 PASS 1.03s github.com/netboxlabs/orb-agent/agent/policymgr 71.2% 10 0 0
🟢 PASS 29.53s github.com/netboxlabs/orb-agent/agent/secretsmgr 48.9% 54 0 0
🟢 PASS 1.02s github.com/netboxlabs/orb-agent/agent/telemetry 81.7% 19 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/version 100.0% 1 0 0

Total coverage: 57.5%

@leoparente leoparente requested a review from MicahParks October 23, 2025 12:38
@leoparente leoparente marked this pull request as ready for review October 24, 2025 14:40
Copy link
Contributor

@jajeffries jajeffries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@leoparente leoparente merged commit 3e97a49 into develop Oct 24, 2025
5 checks passed
@leoparente leoparente deleted the feat/env-file-and-default-config branch October 24, 2025 16:29
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants