-
Notifications
You must be signed in to change notification settings - Fork 12
feat: authenticates using oauth2 #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajeffries
commented
Sep 24, 2025
|
Go test coverage
Total coverage: 60.1% |
leoparente
reviewed
Sep 24, 2025
leoparente
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the fleet configuration manager to support extracting connection parameters and agent identity from JWT claims, rather than relying on legacy fields. It introduces a new
parseJWTClaimsfunction to robustly parse and validate JWT claims, updates MQTT authentication logic, and revises heartbeat message structure for improved schema compliance. Tests are updated to reflect these changes and ensure correctness.JWT Claims Extraction and Usage
parseJWTClaimsfunction to extractorb:org_id,orb:zone,client_id,orb:agent_id, andorb:mqtt_urlfrom JWT tokens, replacing legacy claim usage and improving robustness. (agent/configmgr/fleet.go)agent/configmgr/fleet.go) [1] [2]MQTT Connection and Authentication
zone:client_idand password as the JWT token, with improved error handling for missing URLs. (agent/configmgr/fleet.go)agent/configmgr/fleet.go) [1] [2]Heartbeat Message Structure
SchemaVersion,TimeStamp, andStatefields, removing legacyAgentIDandVersionfields. (agent/configmgr/fleet.go)agent/configmgr/fleet_test.go) [1] [2] [3]Testing and Validation
agent/configmgr/fleet_test.go) [1] [2] [3] [4]agent/configmgr/fleet_test.go) [1] [2] [3]Token Request Scope
orb.mqtt:agentandorb.mqtt:group, and added theaudienceparameter for improved compatibility with backend authentication. (agent/configmgr/fleet.go)