Skip to content

feat: proper backoff and port number #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2025
Merged

feat: proper backoff and port number #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0eb5c5b
feat: proper backoff and port number
leoparente Oct 2, 2025
0827511
small fixes
leoparente Oct 8, 2025
f649b0f
increase test coverage
leoparente Oct 8, 2025
e082267
worker changes
leoparente Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion agent/backend/devicediscovery/device_discovery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ func (d *deviceDiscoveryBackend) Configure(logger *slog.Logger, repo policies.Po
if d.apiHost, prs = config["host"].(string); !prs {
d.apiHost = defaultAPIHost
}
if d.apiPort, prs = config["port"].(string); !prs {
if port, prs := config["port"]; prs {
d.apiPort = fmt.Sprintf("%v", port)
} else {
d.apiPort = defaultAPIPort
}

Expand Down Expand Up @@ -218,6 +220,13 @@ func (d *deviceDiscoveryBackend) Start(ctx context.Context, cancelFunc context.C
var version string
var readinessErr error
for backoff := range readinessBackoff {
if status := d.proc.Status(); status.Complete {
err := d.proc.Stop()
if err != nil {
d.logger.Error("proc.Stop error", slog.Any("error", err))
}
return errors.New("device-discovery process ended unexpectedly, check log")
}
version, readinessErr = d.Version()
if readinessErr == nil {
d.logger.Info("device-discovery readiness ok, got version ",
Expand Down
Loading
Loading