Feature AppImage #46
Merged
Feature AppImage #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a POC to show the ability to package pktvisor as an AppImage. If we want to build this out for other archs we probably should look into additional tooling.
weyrick
requested changes
Apr 2, 2021
Contributor
weyrick
left a comment
weyrick
left a comment
There was a problem hiding this comment.
Awesome stuff, just a few minor comments.
Closed
weyrick
reviewed
Apr 7, 2021
Updating some wording and adding the `DEV_IMAGE` env var to the appimage build for ease of development.
weyrick
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates an AppImage that contains
pktvisordpktvisor-pcapandpktvisor-cli. This implementation builds the AppImage in a docker using the assets generated by the docker build. Because not all of the assets are statically complied we use Exodus to capture a minimal set of decencies for the AppImageSee Readme for more details on use and building.
Future Steps: