Feat/add support for field config as array #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 3, 2022 12:22
If we have a nested objects, then the field should be defined as path (array of string). This way we will make sure that the raw value will be properly calculated. Also, with this improvement we can remove some value getters from the configuration where path was used in order to get the value.
hdimitrieski
reviewed
Aug 3, 2022
| export const getRawValueResolver = ({field}: DataGridColumnWithId): ColumnValueGetter => R.prop(field); | ||
| export const getRawValueResolver = ({field}: DataGridColumnWithId): ColumnValueGetter => isString(field) | ||
| ? R.prop(field) | ||
| : R.path(field); |
Contributor
There was a problem hiding this comment.
What happens if the field or its parent is null or undefined? Can you add a test case?
Collaborator
Author
There was a problem hiding this comment.
In that case the raw value resolver will return 'undefined'.
trajchen
approved these changes
Aug 3, 2022
added 3 commits
August 4, 2022 10:58
On the components ngrx-grid-header-item and ngrx-dynamic-grid-header-item we do not apply the defined width. This width is applied on upper level, on parent components. In order to make sure that the right column width will be used, and that the test will not depended on the screen where it is executed we will use elementWidth instead of column.width.
hdimitrieski
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.