docs: document reserved dm key and fail-closed audience parsing#33
Merged
Merged
Conversation
The Slack and Discord audience override sections showed the "dm" key in a ChannelAudiences example without explaining it. Note that "dm" is reserved (matches every direct message, not a channel ID), that a channel-ID entry takes precedence over it, and that an unrecognized audience value is denied rather than defaulted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Documents two previously unstated details in the Slack and Discord Audience overrides sections.
"dm"key in aChannelAudiencesmap is reserved — it matches every direct message rather than a channel ID. The pages showed"dm"in an example without explaining it."dm"fallback.Why
Both behaviors are enforced in
src/Netclaw.Channels/AudienceResult.cs(shared by Slack and Discord). The fail-closed detail used to live in the Hardening page's Slack section, which was made channel-agnostic in #32 — these facts belong on the channel pages where the config is documented.Verification
npm run buildpasses (55 pages).