ci: fix mislabeled "Upload Linux install script" step (#1031)#1050
Merged
Aaronontheweb merged 1 commit intoMay 18, 2026
Merged
Conversation
install.sh is the unified Unix installer — it handles both Linux and macOS (uname -s -> darwin -> osx-arm64, incl. Apple Silicon / Rosetta). The step name "Upload Linux install script to R2" made it look, during the 0.18.1 release, like the macOS installer had not been published and nearly triggered an unnecessary patch release. Rename the step for accuracy. Purely cosmetic — no artifact or behavior change. Closes netclaw-dev#1031
Aaronontheweb
added
cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/install.shis the unified Unix installer — it handles both Linux and macOS (uname -s→darwin→osx-arm64, including Apple Silicon / Rosetta detection). But the R2-upload step inpublish_release_binaries.ymlwas named "Upload Linux install script to R2".During the 0.18.1 release (first to ship
osx-arm64), that name made it look like the macOS installer hadn't been uploaded and nearly triggered an unnecessary 0.18.2 patch release. The artifact, manifest, and macOS-awareinstall.shwere all published correctly — the only defect was the misleading step name.Renamed the step to "Upload Unix (Linux + macOS) install script to R2" and added a one-line comment. Purely cosmetic — no artifact or behavior change.
Closes #1031