test(reminders): fix deferred expiry race by Aaronontheweb · Pull Request #1053 · netclaw-dev/netclaw

Aaronontheweb · 2026-05-18T04:27:26Z

Summary

make the deferred recurring reminder expiry test deterministic
queue the expiring reminder before the saturation wait so it expires while still deferred
keep the fix isolated from PR fix(sessions): journal tool approval recovery #1044 session approval work

dotnet test src/Netclaw.Actors.Tests/Netclaw.Actors.Tests.csproj --filter "FullyQualifiedName~Deferred_expired_recurring_reminder_is_disabled_before_execution" --no-restore
dotnet test src/Netclaw.Actors.Tests/Netclaw.Actors.Tests.csproj --filter "FullyQualifiedName~ReminderManagerActorTests" --no-restore
dotnet slopwatch analyze
pwsh ./scripts/Add-FileHeaders.ps1 -Verify
git diff --check

Aaronontheweb · 2026-05-18T04:30:55Z


            manager.Tell(CreateEnvelope(expiringId));

+            await AwaitAssertAsync(async () =>


Moved this assertion until after we've sent the creation request to the manager,.

test(reminders): fix deferred expiry race

f31faf1

Aaronontheweb enabled auto-merge (squash) May 18, 2026 04:27

Aaronontheweb added the tests All issues related to testing, quality assurance, and smoke testing. label May 18, 2026

Merge branch 'dev' into fix/windows-reminder-deferred-expiry-race

7cdc50f

Aaronontheweb commented May 18, 2026

View reviewed changes

Aaronontheweb merged commit 73f2d5b into netclaw-dev:dev May 18, 2026
15 checks passed


		manager.Tell(CreateEnvelope(expiringId));

		await AwaitAssertAsync(async () =>