fix(tests): register reminder services in LlmSessionTestBase#1066
Merged
Conversation
WithNetclawActors() starts ReminderManagerActor, which resolves SchedulingConfig, ReminderDefinitionStore, ReminderHistoryStore, and IOperationalNotificationSink from DI. LlmSessionTestBase never registered them, so the actor failed activation (ActorInitializationException) on every session integration test -- harmless to assertions but spamming ERROR logs and adding startup churn that can tip slow CI runners over a tight ExpectMsg timeout. Register the four services (mirroring Netclaw.Daemon's Program.cs) before ConfigureSessionServices so derived classes can still override them. ReminderManagerActor now starts cleanly in all 34 LlmSessionIntegrationTests.
Aaronontheweb
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithNetclawActors()startsReminderManagerActor, which resolvesSchedulingConfig,ReminderDefinitionStore,ReminderHistoryStore, andIOperationalNotificationSinkfrom DI.LlmSessionTestBasenever registeredthem, so the actor failed activation (
ActorInitializationException→InvalidOperationException: Unable to resolve service) on every sessionintegration test — harmless to assertions, but spamming ERROR-level logs and
adding actor-startup churn.
This registers the four services in
LlmSessionTestBase.ConfigureServices,mirroring
Netclaw.Daemon'sProgram.cs, beforeConfigureSessionServicesso a derived class can still override them.
Verified via TRX log scan over
LlmSessionIntegrationTests(34 tests):Error while creating actor instance/Unable to resolve service/ActorInitializationExceptionall go 34 → 0, replaced byReminderManagerActor started (scheduling enabled=True).Context
Surfaced while investigating a transient Windows CI timeout in
Delivery_failed_while_processing_newer_turn_is_ignored. This actor failure isnot the direct cause of that flake — the test passes on Linux/macOS with the
error present — but it is a genuine harness defect and removes a source of
startup ERROR-log churn on the path that flaked.
Test plan
LlmSessionIntegrationTests— 34/34 passdotnet slopwatch analyze— 0 issuesAdd-FileHeaders.ps1 -Verify— pass