feat(tools): classify multimodal file reads#1240
Merged
Aaronontheweb merged 9 commits intoMay 31, 2026
Merged
Conversation
Aaronontheweb
added
the
tools
Aaronontheweb
commented
May 30, 2026
Collaborator
Author
|
I have some thoughts on the code quality in this PR but I'm going to see what CoPilot comes up with first |
Aaronontheweb
commented
May 31, 2026
Collaborator
Author
Aaronontheweb
left a comment
Aaronontheweb
left a comment
There was a problem hiding this comment.
Merging now to stall PR growth, but turning around and immediately refactoring and cleaning a few things up.
Collaborator
Author
There was a problem hiding this comment.
Unrelated racy test bug fix.
| return; | ||
|
|
||
| var itemText = mediaReferences.Count == 1 ? "file" : "files"; | ||
| _state = _state.AddSystemNudge( |
Collaborator
Author
There was a problem hiding this comment.
we'll have to see how well this works in-practice.
|
|
||
| namespace Netclaw.Security; | ||
|
|
||
| public static class MimeTypeCatalog |
Collaborator
Author
There was a problem hiding this comment.
We're going to consolidate / clean this stuff in a subsequent PR - too many competing file type primitives floating around in the code base right now.
| /// <summary> | ||
| /// Describes a file a tool wants to add to the next LLM call as model input. | ||
| /// </summary> | ||
| public sealed record ModelInputFileInfo(string FilePath, string FileName, string MimeType); |
Collaborator
Author
There was a problem hiding this comment.
Need to use value objects here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1237
Validation
Notes