feat(install): add download progress indicators to installer scripts#246
Merged
Conversation
Bash: use curl --progress-bar when stderr is a TTY, falls back to silent in non-interactive contexts (CI). PowerShell: spinner via background runspace avoids PS 5.1 Write-Progress performance penalty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curl --progress-barwhen stderr is a TTY to show a###progress bar with percentage during binary downloads. Falls back to silent in non-interactive contexts (CI).|/-\) via background runspace whileInvoke-WebRequestruns with$ProgressPreference = 'SilentlyContinue'. Avoids the notorious PS 5.1Write-Progressperformance penalty (10x slower downloads). Falls back to static message in non-interactive contexts.Test plan
bash scripts/install.sh— confirm###progress bar appears during downloadbash scripts/install.sh 2>/dev/null— confirm clean silent download.\scripts\install.ps1— confirm spinner animates during download