fix(config): exclude secrets.json from config watcher restart trigger#373
Merged
Conversation
…#372) ConfigWatcherService watched both netclaw.json and secrets.json, so OAuth token refreshes (which write to secrets.json) triggered daemon restarts mid-session. Narrow IsWatchedFile to only netclaw.json — secret changes are loaded on-demand and never require a restart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #372.
ConfigWatcherServicewatched bothnetclaw.jsonandsecrets.json, so OAuth token refreshes (which write tosecrets.json) triggered daemon restarts mid-session, killing active turnsIsWatchedFileto onlynetclaw.json— secret changes are loaded on-demand and never require a restartsecrets.jsonJSON validation fromApplyReloadTest plan
ConfigWatcherServiceTestspass (9 tests)NonConfigFiles_AreNotWatchedtheory coverssecrets.json,mcp-oauth-metadata.json,random.txt, andnullNetclawJson_IsWatchedconfirmsnetclaw.jsonstill triggers restart