feat(security): add minisign signature verification to netclaw update#393
Merged
Conversation
…#390) Closes the client-side verification gap: the release pipeline already signs manifest.json with minisign, but the client never checked. Now every manifest fetch (update command, daemon startup, background check, doctor, status) verifies the Ed25519 signature against an embedded public key before trusting the manifest contents. Fail-closed — missing or invalid signatures reject the manifest. Also converts BinaryUpdateCheckService to a BackgroundService with a 24-hour periodic recheck timer and emits UpdateAvailable operational alerts through the existing webhook notification infrastructure. Closes #390
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manifest.jsonbefore trusting its contents duringnetclaw updateand all background update checksmanifest.json.sigalongside the manifest; fails loudly if signature is missing or invalid (fail-closed, no fallback to unsigned)feeds/releases/manifest.pubas a compiled constant — no CDN dependency for verificationBinaryUpdateCheckServicefromIHostedServicetoBackgroundServicewith 24-hour periodic recheck timerUpdateAvailableoperational alert via existing webhook notification infrastructure when updates are detectedNSec.Cryptography(libsodium wrapper) for Ed25519 verification — .NET 10 lacks built-in Ed25519Closes #390
Test plan
ManifestFetchStatus, tampered manifest rejected, alert emitted/not emitteddotnet slopwatch analyze— no new violations