fix(tools): web_fetch saves binary content with correct extension and raw bytes#461
Merged
Merged
Conversation
…386) web_fetch was reading all HTTP responses as UTF-8 strings and saving non-HTML content with .txt extension. Binary files (images, PDFs) were mangled, breaking the attach_file workflow for Slack delivery. - Add binary content detection via Content-Type header (image/*, audio/*, video/*, application/pdf, etc.) with raw byte[] save path - Use URL path extension first (.png, .sh, .json), fall back to Content-Type mapping only when URL has no extension - Filter out numeric-only "extensions" like .25414 (arxiv version IDs) - Extract shared BuildFilePath helper to deduplicate save methods - Have ReadTextWithLimitAsync delegate to ReadBytesWithLimitAsync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #386 —
web_fetchwas reading all HTTP responses as UTF-8 strings and saving non-HTML content with.txtextension. Binary files (images, PDFs) were mangled, breaking theattach_fileworkflow for Slack delivery.Content-Typeheader (image/*,audio/*,video/*,application/pdf, etc.) with rawbyte[]save path.png,.sh,.json), fall back toContent-Typemapping only when URL has no extension.25414(arxiv version IDs)BuildFilePathhelper to deduplicate save methodsReadTextWithLimitAsyncdelegate toReadBytesWithLimitAsyncTest plan
.pngextension, byte-perfect verification.pdffrom Content-Type.json,.sh) preserved instead of.txt.binIsBinaryContentType,GetExtensionFromUrl,GetFallbackExtension