Skip to content

deploy netdata using the nodiscc.xsrv.monitoring_netdata ansible role#42

Merged
maneamarius merged 1 commit into
netdata:mainfrom
nodiscc:ansible-xsrv2
Jun 30, 2022
Merged

deploy netdata using the nodiscc.xsrv.monitoring_netdata ansible role#42
maneamarius merged 1 commit into
netdata:mainfrom
nodiscc:ansible-xsrv2

Conversation

@nodiscc
Copy link
Copy Markdown
Contributor

@nodiscc nodiscc commented Apr 22, 2022

/cc @odyslam

@nodiscc
Copy link
Copy Markdown
Contributor Author

nodiscc commented May 2, 2022

/cc @ilyam8 @cakrit it seems you are the new maintainers.

Are you still interested in adding this documentation?

@ilyam8 ilyam8 requested a review from ReifiedException May 3, 2022 07:30
Comment thread netdata-agent-deployment/ansible-xsrv/README.md Outdated
@nodiscc nodiscc requested a review from ilyam8 May 15, 2022 17:19
@ilyam8 ilyam8 requested a review from a team May 15, 2022 20:00
@nodiscc
Copy link
Copy Markdown
Contributor Author

nodiscc commented Jun 28, 2022

@ilyam8 ok to merge?

@ilyam8 ilyam8 requested a review from Ferroin June 28, 2022 15:31
@ilyam8
Copy link
Copy Markdown
Member

ilyam8 commented Jun 28, 2022

@nodiscc sorry for the delay. @Ferroin and @maneamarius will take a look (I hope) soon.

@ReifiedException
Copy link
Copy Markdown

ReifiedException commented Jun 28, 2022

As far as I remember, it was decided that we will not offer the community automation solutions. We had a meeting. Why we are talking about it again?

@andrewm4894
Copy link
Copy Markdown
Contributor

andrewm4894 commented Jun 28, 2022

If the pr might help some future users why would we not merge it?

Also the pr seems to add a new tree to the folder so it's not like it's going to break anything.

Without being an expert or even all that knowledgeable on Ansible this looks like a great community contribution to me and exactly the sort of thing this repo is for.

@ReifiedException
Copy link
Copy Markdown

Going back to that discussion, the reasons for not doing it are roughly the following.
This way we sort of take responsibility for this code. We would be more comfortable giving links to the repositories of those who developed the relevant playbook/role.
This particular role is (from memory) well written, but its usefulness is extremely limited by the fact that it only works with
Debian 11. Since there are no organizations that use a single version of a single operating system, more generic roles will be preferred.
Also, Ansible is not the only automation tool.
I would prefer to see this role in Ansible Galaxy. And we will, of course, point out its existence in the documentation.

@maneamarius maneamarius self-requested a review June 30, 2022 11:18
@maneamarius maneamarius merged commit 3a030c0 into netdata:main Jun 30, 2022
@andrewm4894
Copy link
Copy Markdown
Contributor

Thanks @nodiscc !

@nodiscc
Copy link
Copy Markdown
Contributor Author

nodiscc commented Jun 30, 2022

Hi @andrewm4894 @iigorkarpov

This way we sort of take responsibility for this code. We would be more comfortable giving links to the repositories of those who developed the relevant playbook/role.

I assumed (see https://gitlab.com/nodiscc/xsrv/-/issues/1) this repository was for listing community-supported projects, which implies netdata does not officially support/take responsibility for the content.

If you feel more comfortable only linking to external projects I suggest converting the repo to an "awesome"-style list (see https://gitea.com/gitea/awesome-gitea for example) which links to community projects or articles on netdata. I can move the article to a Github gist or similar then we can simply link to it from here (then we should also move the other ansible howto).

All things considered I think the "awesome list" format would be more suitable for this repo.

This particular role is (from memory) well written,

Thanks 👌 I try to keep it clean

its usefulness is extremely limited by the fact that it only works with Debian 11. Since there are no organizations that use a single version of a single operating system, more generic roles will be preferred.

It should work with Debian 10/Ubuntu 18/20/22 with minor modifications, which would be maintainable for me.

But you are right that it will not support other distributions/RHEL family because it is out of scope for me. It has other limitations, it only supports the APT/.deb installation method, not all netdata settings are configurable through it... and that is by design. Config management is about standardizing environments and having too many config toggles defeats this purpose (and as the number of configuration variables increases, so does the number of non-working configurations).

If you see another use case for which it could be adapted, please let me know (for example I recently added the possibility to configure streaming in a simplified way).

Ansible is not the only automation tool

This repo could point to other deployment methods/examples/howtos... I think the description/structure should be clarified in this way.

I would prefer to see this role in Ansible Galaxy. And we will, of course, point out its existence in the documentation.

It's there: https://galaxy.ansible.com/nodiscc/xsrv (as a collection):

$ ansible-galaxy collection install nodiscc.xsrv

But I suggest installing from git instead:

# $ cat requirements.yml
collections:
  - name: https://gitlab.com/nodiscc/xsrv.git # from git
    type: git
    version: release
# $ ansible-galaxy collection install --force -r requirements.yml

@nodiscc nodiscc deleted the ansible-xsrv2 branch June 30, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants