Skip to content

New wgetImage settings#180

Merged
knatsakis merged 1 commit intonetdata:masterfrom
dex4er:wget-image
Nov 6, 2020
Merged

New wgetImage settings#180
knatsakis merged 1 commit intonetdata:masterfrom
dex4er:wget-image

Conversation

@dex4er
Copy link
Copy Markdown
Contributor

@dex4er dex4er commented Nov 1, 2020

Hi.

I have to copy all public images to private registry. Then I need to override netdata/wget image with something else.

@odyslam
Copy link
Copy Markdown
Contributor

odyslam commented Nov 5, 2020

@dex4er I see that this your first contribution to the Netdata Community. Thank you so much for taking the time and welcome on-board! ✌️

@dex4er
Copy link
Copy Markdown
Contributor Author

dex4er commented Nov 6, 2020

@dex4er I see that this your first contribution to the Netdata Community. Thank you so much for taking the time and welcome on-board! ✌️

Oh thank you, but it is not my first contribution to the project.

After docker.io introduced usage limits, I have to use local mirror of the Netdata images. I hope you'll release new Helm chart with this patch to the public repository really soon.

@ilyam8
Copy link
Copy Markdown
Member

ilyam8 commented Nov 6, 2020

@dex4er please bump versions

Comment thread charts/netdata/README.md
| `sysctlImage.tag` | sysctlImage Init container tag | `latest` |
| `sysctlImage.pullPolicy` | sysctlImage Init container pull policy | `Always` |
| `sysctlImage.resources` | sysctlImage Init container CPU/Memory resource requests/limits | {} |
| `wgetImage.repository` | wgetImage Init container name | `alpine` |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `wgetImage.repository` | wgetImage Init container name | `alpine` |
| `wgetImage.repository` | wgetImage Init container name | `netdata/wget` |

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched to "alpine" because this is already used by sysctlImage and "alpine" image is correctly tagged with version number, so much easier to clone.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use custom image because we need gnu wget

#92

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can release tagged version of https://github.com/netdata/docker-wget

@knatsakis
Copy link
Copy Markdown
Contributor

Since this is a bit time sensitive I'll go ahead and merge the PR and fix the version and the default value of wgetImage.repository right after.

Thanks @dex4er!

@knatsakis knatsakis merged commit 53e9dc7 into netdata:master Nov 6, 2020
@knatsakis
Copy link
Copy Markdown
Contributor

Here are the commits:

4ec7adf
5a1d31e

@dex4er dex4er deleted the wget-image branch November 6, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants