Skip to content

fix no-key warnings#391

Merged
jacekkolasa merged 1 commit intomasterfrom
fix-no-key-warnings
Oct 27, 2022
Merged

fix no-key warnings#391
jacekkolasa merged 1 commit intomasterfrom
fix-no-key-warnings

Conversation

@jacekkolasa
Copy link
Copy Markdown
Contributor

fix 3 no-key warnings when no actions are provided to the table

@jacekkolasa jacekkolasa requested a review from a team October 26, 2022 08:17

return (
<>
<React.Fragment key={id}>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its safe to complete remove the Fragment here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexNti There are 2 components inside - Action and ColumnsMenu, perhaps you missed it because of how GH collapses the code?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes you correct. I missed that

@jacekkolasa jacekkolasa merged commit 0200545 into master Oct 27, 2022
@jacekkolasa jacekkolasa deleted the fix-no-key-warnings branch October 27, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants