Skip to content

Drop container icon props #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kapantzak merged 2 commits into from
Oct 6, 2025
Merged

Drop container icon props #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f04446
Allow drop container icon props
kapantzak Oct 6, 2025
d4746b1
v5.0.58
kapantzak Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@netdata/netdata-ui",
"version": "5.0.57",
"version": "5.0.58",
"description": "netdata UI kit",
"main": "dist/index.js",
"module": "dist/es6/index.js",
Expand Down
64 changes: 40 additions & 24 deletions src/components/drops/container.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,49 @@
import React from "react"
import React, { Fragment } from "react"
import Flex from "@/components/templates/flex"
import { Text } from "@/components/typography"
import { Icon } from "@/components/icon"

const rotateMap = { right: 1, bottom: 2, left: 3 }
const iconAlignmentProps = { alignSelf: "center" }

const Container = ({ children, align, margin = [1], background = "tooltip", ref, ...rest }) => (
<Flex
ref={ref}
column={align === "top"}
columnReverse={align === "bottom"}
rowReverse={align === "right"}
margin={margin}
>
<Flex background={background} padding={[1, 2]} round column {...rest}>
{typeof children === "string" ? <Text color="tooltipText">{children}</Text> : children}
const Container = ({
children,
align,
margin = [1],
background = "tooltip",
ref,
iconContainerProps = {},
...rest
}) => {
const hasIconContainerProps = !!Object.keys(iconContainerProps)
const IconContainer = hasIconContainerProps ? Flex : Fragment

return (
<Flex
ref={ref}
column={align === "top"}
columnReverse={align === "bottom"}
rowReverse={align === "right"}
margin={margin}
>
<Flex background={background} padding={[1, 2]} round column {...rest}>
{typeof children === "string" ? <Text color="tooltipText">{children}</Text> : children}
</Flex>
{align && (
<IconContainer {...iconAlignmentProps} {...iconContainerProps}>
<Icon
name="triangle"
color={background}
rotate={rotateMap[align]}
height="8px"
width="8px"
data-testid="drop-arrow"
{...(hasIconContainerProps ? {} : iconAlignmentProps)}
/>
</IconContainer>
)}
</Flex>
{align && (
<Icon
name="triangle"
alignSelf="center"
color={background}
rotate={rotateMap[align]}
height="8px"
width="8px"
data-testid="drop-arrow"
/>
)}
</Flex>
)
)
}

export default Container
Loading