Skip to content

Fix button bg #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kapantzak merged 2 commits into from
Nov 4, 2025
Merged

Fix button bg #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af0c5a2
Fix button hover accent color
kapantzak Nov 4, 2025
e729d40
v5.0.67
kapantzak Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@netdata/netdata-ui",
"version": "5.0.66",
"version": "5.0.67",
"description": "netdata UI kit",
"main": "dist/index.js",
"module": "dist/es6/index.js",
Expand Down
19 changes: 15 additions & 4 deletions src/components/button/styled.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,21 @@ const getTextColor = props =>
: getColor(props.flavour === HOLLOW ? "secondaryColor" : "mainBackground")(props)
const getHoverColor = props =>
props.neutral ? getColor("generic")(props) : getColor("accent")(props)
const getAccentColor = props =>
props.neutral
? getColor(props.flavour === BORDER_LESS ? "textFocus" : "neutralHighlight")(props)
: getColor(props.flavour === HOLLOW ? "secondaryHighlight" : "primaryHighlight")(props)

const getAccentColor = props => {
if (props.neutral)
return getColor(props.flavour === BORDER_LESS ? "textFocus" : "neutralHighlight")(props)

const errorColor = props.danger ? "error" : undefined
const errorBgColor = props.danger ? "errorSemi" : undefined
const warningColor = props.warning ? "warning" : undefined
const warningBgColor = props.warning ? "warningSemi" : undefined
const primaryColor = errorColor || warningColor || "primaryHighlight"
const secondaryHollow = errorBgColor || warningBgColor || "secondaryHighlight"

return getColor(props.flavour === HOLLOW ? secondaryHollow : primaryColor)(props)
}

const getTransparent = getColor(["transparent", "full"])

const colorsByFlavour = ({ flavour = DEFAULT, danger, warning, iconColor }) => {
Expand Down