Fix memory corruption issue when executing context queries in RAM/SAVE memory mode#10933
Merged
stelfrag merged 1 commit intonetdata:masterfrom Apr 7, 2021
Conversation
ilyam8
approved these changes
Apr 7, 2021
vlvkobal
approved these changes
Apr 7, 2021
thiagoftsm
approved these changes
Apr 7, 2021
Contributor
thiagoftsm
left a comment
There was a problem hiding this comment.
I tested locally and on cloud and netdata did not crash when I ran netdata using ram.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10929
Summary
Then executing queries in RAM / SAVE mode, the metric_uuid was never properly allocated and
would result in memory corruption.
Component Name
database
web
Test Plan
http://127.0.0.1:19999/api/v1/data?context=net.netrd->state->metric_uuidthat belongs to the original rrddim and result to a crashAdditional Information
Note: This is a temporary fix. A new PR in the next version avoids the memory allocation of the metric_uuid