Skip to content

workers fixes and improvements#12863

Merged
ilyam8 merged 1 commit intonetdata:masterfrom
ktsaou:workers-fixes-1
May 10, 2022
Merged

workers fixes and improvements#12863
ilyam8 merged 1 commit intonetdata:masterfrom
ktsaou:workers-fixes-1

Conversation

@ktsaou
Copy link
Copy Markdown
Member

@ktsaou ktsaou commented May 9, 2022 •
edited
Loading

  1. Eliminated division by zero when running workers exit all together, but the statistics thread is still running
  2. Eliminated division by zero when all threads calling heartbeat_next() exit, but the statistics thread is still running
  3. Updated documentation of workers utilization
  4. Added a chart to show the absolute total CPU utilization of all workers together (100% = 1 core)
  5. Moved API statistics to the api family (were in netdata family)
  6. When a worker was busy for a long time, the busy time chart of the worker was reflecting this, but the job busy time chart was not. At the job busy time, time was accumulated when the worker switched state. Fixed it, so that the job busy time shows the busy time of running jobs too.

thiagoftsm
thiagoftsm approved these changes May 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on Slackware Linux current and FreeBSD 13.0-RELEASE-p11, and everything works. LGTM!

@ilyam8 ilyam8 requested a review from vlvkobal May 10, 2022 06:55
@ilyam8 ilyam8 merged commit 33e20ac into netdata:master May 10, 2022
@ktsaou ktsaou deleted the workers-fixes-1 branch May 10, 2022 15:05
odynik pushed a commit to odynik/netdata that referenced this pull request May 14, 2022
@ktsaou @odynik
workers fixes and improvements (netdata#12863)
f14e877
@ktsaou ktsaou restored the workers-fixes-1 branch December 28, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilyam8 ilyam8 ilyam8 approved these changes

@thiagoftsm thiagoftsm thiagoftsm approved these changes

@stelfrag stelfrag stelfrag approved these changes

@DShreve2 DShreve2 Awaiting requested review from DShreve2

@vkalintiris vkalintiris Awaiting requested review from vkalintiris

+1 more reviewer

@vlvkobal vlvkobal vlvkobal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/daemon area/docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ktsaou @vlvkobal @ilyam8 @thiagoftsm @stelfrag