Skip to content

remove deprecated fping.plugin in accordance with v1.37.0 deprecation notice #14073

Merged
ilyam8 merged 2 commits into
netdata:masterfrom
ilyam8:rm_fping.plugin
Dec 9, 2022
Merged

remove deprecated fping.plugin in accordance with v1.37.0 deprecation notice #14073
ilyam8 merged 2 commits into
netdata:masterfrom
ilyam8:rm_fping.plugin

Conversation

@ilyam8
Copy link
Copy Markdown
Member

@ilyam8 ilyam8 commented Nov 30, 2022

Summary

This PR removes the following plugins (v1.37.0 deprecation notice):

  • fping.plugin
Test Plan
  • ci.
  • git grep fping.
Additional Information
For users: How does this change affect me?

@github-actions github-actions Bot added area/build Build system (autotools and cmake). area/ci area/collectors Everything related to data collection area/docs area/health area/packaging Packaging and operating systems support area/tests area/web collectors/fping collectors/plugins.d labels Nov 30, 2022
@ilyam8 ilyam8 marked this pull request as ready for review November 30, 2022 21:44
@ilyam8 ilyam8 changed the title remove deprecated fping.plugin in accordance with v1.370 deprecation notice remove deprecated fping.plugin in accordance with v1.37.0 deprecation notice Nov 30, 2022
@thiagoftsm
Copy link
Copy Markdown
Contributor

@ilyam8 is there a specific reason to keep directory collectors/fping.plugin?

@ilyam8
Copy link
Copy Markdown
Member Author

ilyam8 commented Nov 30, 2022

@thiagoftsm no, where do you see it?

@ktsaou
Copy link
Copy Markdown
Member

ktsaou commented Nov 30, 2022

Do we have a replacement?

@thiagoftsm
Copy link
Copy Markdown
Contributor

Do we have a replacement?

Yes @ktsaou , we have a GO module now .

@thiagoftsm
Copy link
Copy Markdown
Contributor

@thiagoftsm no, where do you see it?

Sorry, it was my fault, git kept directory with files when I changed for your branch 🤦‍♂️

@kingUFU

This comment was marked as spam.

@ilyam8 ilyam8 merged commit 4322b19 into netdata:master Dec 9, 2022
@ilyam8 ilyam8 deleted the rm_fping.plugin branch December 9, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build system (autotools and cmake). area/ci area/collectors Everything related to data collection area/docs area/health area/packaging Packaging and operating systems support area/tests area/web collectors/fping collectors/plugins.d

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants