fix health emphemerality labels src#14105
Merged
Merged
Conversation
ilyam8
requested review from
MrZammler,
thiagoftsm and
vkalintiris
as code owners
thiagoftsm
previously approved these changes
Dec 7, 2022
Contributor
thiagoftsm
left a comment
thiagoftsm
left a comment
There was a problem hiding this comment.
We have previous scenario set:
netdata.hades.logind.sessions_state.active 1 1670440689
netdata.hades.logind.users_state.offline 0 1670440689
netdata.hades.logind.users_state.closing 0 1670440689
netdata.hades.logind.users_state.online 0 1670440689
netdata.hades.logind.users_state.lingering 0 167044068Graphite was also showing names again:
MrZammler
previously approved these changes
Dec 8, 2022
Contributor
MrZammler
left a comment
MrZammler
left a comment
There was a problem hiding this comment.
I think it's ok, even if when set by the user and exports they would have the problem again.
What we discussed in slack, maybe set them as AUTO or use another to indicate set by user but really internal.
MrZammler
approved these changes
Dec 8, 2022
thiagoftsm
approved these changes
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #14084
_is_ephemeraland_has_unstable_connectionlabels src is configExporting configured labels is enabled by default.
It causes problems even though the format is correct (🤷)
I doubt we were going to export those labels anyway. I am not sure my fix is correct, but I think it is acceptable as a quick fix.
Test Plan
Build docker images, configure graphite exporter, and check exporter metrics.
Additional Information
For users: How does this change affect me?