fix(packaging): add setuid for cgroup-network and ebpf.plugin in RPM#14140
Merged
Conversation
ilyam8
commented
Dec 13, 2022
| # Conditional build: | ||
| %bcond_without systemd # systemd | ||
| %bcond_with netns # build with netns support (cgroup-network) | ||
| %bcond_without netns # build with netns support (cgroup-network) |
Member
Author
There was a problem hiding this comment.
@Ferroin I am not sure why we need this condition at all 🤷♂️ Do you remember/know?
Member
There was a problem hiding this comment.
It’s a leftover from CentOS 6, but it’s also probably not worth making the effort right now to completely remove it.
Member
There was a problem hiding this comment.
Correction, this is planned for removal as part of #13927, once I finally get back to working on that. So no need to drop it here and make this PR more complicated than it needs to be.
github-actions
Bot
added
the
area/packaging
thiagoftsm
approved these changes
Dec 13, 2022
Ferroin
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #14132
This PR fixes the lack of setuid bit for:
In fact, it doesn't really fix #14132, but it is up to @Ferroin if we want to keep the issue open.
Test Plan
Additional Information
For users: How does this change affect me?