Fixes required to make the agent work without crashes on MacOS#14304
Merged
Conversation
On systems with a low soft-limit for open file descriptors, the agent would fail to initialize all dbengine tiers.
For whatever reason, this was causing a crash on MacOS but it was running "correctly" on Linux systems.
vkalintiris
requested review from
Dim-P,
MrZammler,
ilyam8,
stelfrag and
underhood
ktsaou
approved these changes
Jan 20, 2023
thiagoftsm
approved these changes
Jan 20, 2023
Contributor
thiagoftsm
left a comment
thiagoftsm
left a comment
There was a problem hiding this comment.
I do not have Mac, but on FreeBSD everything is working as expected, LGTM!
stelfrag
approved these changes
Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The agent would crash on startup on MacOS systems because:
journalfile_v2_mounted_data_unmount()would iterate tiers that have not been initialized.Test Plan