Add metadata.csv to python.d.plugin#14959
Merged
Ancairon merged 46 commits intonetdata:masterfrom Apr 27, 2023
Merged
Conversation
Ancairon
requested review from
andrewm4894,
cakrit,
ilyam8 and
tkatsoulas
as code owners
github-actions
Bot
added
area/collectors
cakrit
suggested changes
Apr 25, 2023
Contributor
cakrit
left a comment
cakrit
left a comment
There was a problem hiding this comment.
I don't want a link to a csv in the documentation. Convert these to tables of metrics in markdown format please.
Create a small script that just does that for now (takes as input the csv and spits out the markdown table). An additional manual step is then needed to edit the readme.
The script may eventually be extended enough to generate the whole markdown document, but that's not a requirement for now.
Member
Author
|
@cakrit my thought was that we are going to introduce the same text everywhere, and then the ingest would do that conversion. It should not be that hard, and we can replace this text with a table, automatically. I can work on that once we are finished with these additions. |
Ancairon
changed the title
ilyam8
approved these changes
Apr 27, 2023
thiagoftsm
approved these changes
Apr 27, 2023
cakrit
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As the title suggests, this PR adds metadata.csv to some modules.
'health_idle'gets assigned, can't find the dimension assignment, left it asNonefor now)