Skip to content

Optimizations Part 2#15267

Merged
ktsaou merged 3 commits intonetdata:masterfrom
ktsaou:gperf-part-2
Jun 28, 2023
Merged

Optimizations Part 2#15267
ktsaou merged 3 commits intonetdata:masterfrom
ktsaou:gperf-part-2

Conversation

@ktsaou
Copy link
Copy Markdown
Member

@ktsaou ktsaou commented Jun 27, 2023 •
edited
Loading

  • Speed up processing of streaming and plugins by eliminating function pointers and using a switch statement.
  • MRG now uses a dynamic number of partitions based on the number of CPU cores available (it was always 10).

@ktsaou ktsaou requested a review from thiagoftsm as a code owner June 27, 2023 22:17
@github-actions github-actions Bot added area/collectors Everything related to data collection collectors/plugins.d labels Jun 27, 2023
@ktsaou ktsaou requested a review from vkalintiris as a code owner June 27, 2023 22:54
@ktsaou ktsaou changed the title pluginsd/streaming gperf with inline functions Optimizations Part 2 Jun 27, 2023
@ktsaou ktsaou merged commit b52a989 into netdata:master Jun 28, 2023
@ktsaou ktsaou mentioned this pull request Jun 28, 2023
Merged
ktsaou added a commit that referenced this pull request Jun 28, 2023
@ktsaou
Revert "Optimizations Part 2 (#15267)"
f07a318 
This reverts commit b52a989.
ktsaou added a commit that referenced this pull request Jun 28, 2023
@ktsaou
Revert "Optimizations Part 2" (#15279)
a88c968 
Revert "Optimizations Part 2 (#15267)"

This reverts commit b52a989.
@ktsaou ktsaou mentioned this pull request Jun 29, 2023
Merged
9 tasks
Ancairon pushed a commit that referenced this pull request Jul 3, 2023
@ktsaou @Ancairon
Optimizations Part 2 (#15267)
7644994 
* make all pluginsd functions inline, instead of function pointers

* dynamic MRG partitions based on the number of CPUs

* report the right size of the MRG
Ancairon pushed a commit that referenced this pull request Jul 3, 2023
@ktsaou @Ancairon
Revert "Optimizations Part 2" (#15279)
376c5a6 
Revert "Optimizations Part 2 (#15267)"

This reverts commit b52a989.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stelfrag stelfrag stelfrag approved these changes

@thiagoftsm thiagoftsm Awaiting requested review from thiagoftsm

@vkalintiris vkalintiris Awaiting requested review from vkalintiris

Assignees

No one assigned

Labels

area/collectors Everything related to data collection area/daemon area/database area/web collectors/plugins.d

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ktsaou @stelfrag