Merged
Conversation
github-actions
bot
added
area/collectors
thiagoftsm
force-pushed
the
ebpf_cgroup_update
branch
from
8ead068 to
3dceeb6
Compare
thiagoftsm
force-pushed
the
ebpf_cgroup_update
branch
from
3dceeb6 to
b750a0d
Compare
thiagoftsm
force-pushed
the
ebpf_cgroup_update
branch
from
b750a0d to
945a7f7
Compare
thiagoftsm
force-pushed
the
ebpf_cgroup_update
branch
2 times, most recently
from
aa93daa to
0838abb
Compare
thiagoftsm
force-pushed
the
ebpf_cgroup_update
branch
from
0838abb to
1ef5340
Compare
thiagoftsm
force-pushed
the
ebpf_cgroup_update
branch
3 times, most recently
from
7f97834 to
bae7f48
Compare
thiagoftsm
force-pushed
the
ebpf_cgroup_update
branch
2 times, most recently
from
29c20a6 to
d036153
Compare
thiagoftsm
force-pushed
the
ebpf_cgroup_update
branch
3 times, most recently
from
e1a572a to
e896d0d
Compare
stelfrag
reviewed
Mar 4, 2024
stelfrag
reviewed
Mar 4, 2024
stelfrag
reviewed
Mar 4, 2024
thiagoftsm
force-pushed
the
ebpf_cgroup_update
branch
from
e896d0d to
74e9727
Compare
ilyam8
reviewed
Mar 5, 2024
|
|
||
| ebpf_cgroup_target_t *w; | ||
| for (w = ebpf_cgroup_pids; w; w = w->next) { | ||
| if (unlikely(!w->systemd || (w->systemd && w->flags & NETDATA_EBPF_SERVICES_HAS_CACHESTAT_CHART))) |
Member
There was a problem hiding this comment.
Suggested change
| if (unlikely(!w->systemd || (w->systemd && w->flags & NETDATA_EBPF_SERVICES_HAS_CACHESTAT_CHART))) | |
| if (unlikely(!w->systemd || (w->flags & NETDATA_EBPF_SERVICES_HAS_CACHESTAT_CHART))) |
…ginners, but I agree this is shorter. :)
thiagoftsm
force-pushed
the
ebpf_cgroup_update
branch
from
4dc0578 to
19f956b
Compare
stelfrag
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Blocked by #16671.
This PR modifies cgroup integration to have charts per
serviceinstead of group them in one unique chart.It also moves from main thread to discovery thread, the integration between plugins.
Finally, it fixes a race condition.
Test Plan
/etc/netdata/ebpf.d.conf:[global] cgroups = yes [ebpf programs] cachestat = yes dcstat = yes fd = yes oomkill = yes process = yes shm = yes socket = yes swap = yes vfs = yesAdditional Information
For users: How does this change affect me?