Skip to content

Improve dbengine memory protection message on startup#22045

Merged
stelfrag merged 2 commits intonetdata:masterfrom
stelfrag:improve_dbengine_message
Mar 27, 2026
Merged

Improve dbengine memory protection message on startup#22045
stelfrag merged 2 commits intonetdata:masterfrom
stelfrag:improve_dbengine_message

Conversation

@stelfrag
Copy link
Copy Markdown
Collaborator

Summary
  • Improve log messages to better communicate DBENGINE's memory protection state and actions.

- Improve log messages to better communicate DBENGINE's memory protection state and actions.
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@stelfrag stelfrag marked this pull request as ready for review March 26, 2026 08:37
Copilot AI review requested due to automatic review settings March 26, 2026 08:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates DBENGINE startup logs to better communicate when memory protection is enabled/disabled and what Netdata will do in response.

Changes:

  • Rephrases the “Out of Memory Protection” notice log to describe the intended safety behavior more plainly.
  • Improves the warning log when system memory size cannot be detected, explaining the resulting disabled features.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runnig this PR, no issue was found during startup. LGTM!

@stelfrag stelfrag merged commit 084336f into netdata:master Mar 27, 2026
150 of 152 checks passed
@stelfrag stelfrag deleted the improve_dbengine_message branch March 27, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants